> >On 4/2/2020 4:06 PM, pvnnikhil...@gmail.com wrote: >> From: Pavan Nikhilesh <pbhagavat...@marvell.com> >> >> Make ALLOW_EXPERIMENTAL_API global across lib, drivers and apps. >> >> Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com> > >I am OK to not require this flag for DPDK internally. > >But I remember this has been suggested when __rte_experimental >implemented but >rejected that time, and forced the flag for internals too.
Yup, based on discussion at http://mails.dpdk.org/archives/dev/2020-April/161527.html > >> @@ -9,7 +9,6 @@ include $(RTE_SDK)/mk/rte.vars.mk >> LIB = librte_pmd_ionic.a >> >> # Required to use rte_eth_dev_create and rte_eth_dev_destroy >> -CFLAGS += -DALLOW_EXPERIMENTAL_API > >Some of the flags have comments around them to clarify why the flag is >required, >I was mainly requesting it to manange when to remove this flag, those >comments >also should be removed. Ack, I got most of them but missed this one will send v2. Also I think having the entire maintainer list in cc is a bad idea, will skip using --to-cmd ./devtools/get-maintainer.sh in the next set.
