19/03/2020 14:50, Viacheslav Ovsiienko: > There is the CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES configuration > parameter enabling the lightweight profiler for the forwarding > routines that provides the time spent in the routines and estimates > the CPU cycles required to process one packet. > > It would be good to have separated data for the Rx and Tx directions. > Beside this, the performance depends on the actual burst size, the profiling > data per burst size are meaningful and would help detect the performance > anomalies. > > To control this profiling statistics the new testpmd command is introduced: > > set fwdprof (flags) > > This command controls which profiling statistics is being gathered > in runtime: > > - bit 0 - enables profiling the entire forward routine, counts the ticks > spent in the forwarding routine, is set by default. Provides > the same data as previous implementation. > > - bit 1 - enables gathering the profiling data for the transmit datapath, > counts the ticks spent within rte_eth_tx_burst() routine, > is cleared by default, extends the existing statistics. > > - bit 2 - enables gathering the profiling data for the receive datapath, > counts the ticks spent within rte_eth_rx_burst() routine, > is cleared by default, extends the existing statistics.
Please can you rename bit 1 to Rx, and bit 2 to Tx, and implement configuration with text parsing instead of obscure bitflags? It would be more user-friendly, thanks.