01/04/2020 10:27, Gavin Hu: > Hi Thomas, > > From: Thomas Monjalon <tho...@monjalon.net> > > > > Hi, > > > > 09/03/2020 10:54, Joyce Kong: > > > Bitwise operation APIs are defined and used in a lot of PMDs, > > > which caused a huge code duplication. > > > > Statistics of the series: 653 insertions(+), 326 deletions(-) > > I would not say it is a huge duplication. > We did not include all PMDs, just a few for piloting and seeking opinions. > It is a huge duplication when counting all the PMDs. > > > > > To reduce duplication, > > > this patch consolidates them into a common API family. > > [...] > > > +PMD Bitops > > > +M: Joyce Kong <joyce.k...@arm.com> > > > +F: lib/librte_eal/common/include/rte_pmd_bitops.h > > > > Why is it called PMD bitops and not simply bitops? > > The scope of these APIs are decreased to PMD use only, for > libraries/applications, it is recommended to use C11 directly as there are > complications of more ordering models involved.
OK, but PMD means nothing, except this is where it is used *now*. Please describe and name the API with memory ordering words.
