On Mon, Mar 30, 2020 at 4:22 PM David Marchand
<david.march...@redhat.com> wrote:
> On Fri, Mar 27, 2020 at 2:16 AM Thomas Monjalon <tho...@monjalon.net> wrote:
> >
> > Some clean-up is done in EAL sub-directories.
> > The goal is to make organization easier to understand,
> > and to prepare moving some files from common to Unix-only place.
> >
> > Since the kernel modules are moved to kernel/ directory,
> > there is no need anymore for the sub-directory eal/ in
> > linux/, freebsd/ and windows/.
> >
> > The EAL API (with doxygen documentation) is moved from
> > common/include/ to include/, which makes more clear that
> > it is the global API for all environments and architectures.
> > Note that the arch-specific and OS-specific include files are not
> > in this global include directory, but include/generic/ should
> > cover the doxygen documentation for them.
> >
> > The arch-specific directories arm, ppc_64 and x86 in common/arch/
> > and in common/include/arch are moved at the same level as the
> > OS-specific directories, adding an include/ sub-directory.
> > It makes more clear that EAL is covering a matrix combining OS and arch.
> > Note that ppc_64 is renamed to ppc.
> >
> > These moves offer the opportunity to simplify the make and meson files.
> >
> >
> > This change was proposed to the Technical Board in advance:
> > http://mails.dpdk.org/archives/dev/2020-January/156732.html
>
> I caught an issue on patch 6 that breaks headers installation with
> meson (caught this by compiling examples against an installed dpdk).
> This issue is fixed by patch 7.
> So it is only a matter of fixing compilation when bisecting.
> I proposed a fix in reply to patch 6, which I intend to squash in when 
> applying.
>
>
> I did not validate all patches individually with make, as I get build
> errors on missing headers with parallel compilation quite easily.
> But those errors are transient afaiu: with a clean build directory no problem.
>
>
> For the series:
> Acked-by: David Marchand <david.march...@redhat.com>

Series applied with change in patch 6.


-- 
David Marchand

Reply via email to