> -----Original Message-----
> From: Cui, LunyuanX <lunyuanx....@intel.com>
> Sent: Wednesday, March 18, 2020 11:15 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>;
> Wu, Jingjing <jingjing...@intel.com>; Cui, LunyuanX
> <lunyuanx....@intel.com>
> Subject: [PATCH v2] net/i40e: enable MAC address as FDIR input set
>
> FVL enable both src MAC address and dst MAC address as FDIR's input set
> for ipv4-other. And FVL enable only dst MAC address as FDIR's input set for
> ipv4-other.
Why emphasize input set 'src MAC address and dst MAC address' and ' dst MAC
address ' as input set?
Can't we support src MAC only?
When OVS-DPDK is working as a pure L2 switch, Both two ways
> match offload with Mark+RSS action would help the performance speed up.
> And FVL FDIR supports to change input set as both two ways.
>
> Signed-off-by: Lunyuan Cui <lunyuanx....@intel.com>
>
> ---
> v2:
> - Enable src MAC address as FDIR's input set
> ---
> doc/guides/rel_notes/release_20_05.rst | 7 +++
> drivers/net/i40e/i40e_ethdev.c | 1 +
> drivers/net/i40e/i40e_ethdev.h | 18 +++++++-
> drivers/net/i40e/i40e_fdir.c | 22 +++++++--
> drivers/net/i40e/i40e_flow.c | 63 +++++++++++++++++++-------
> 5 files changed, 89 insertions(+), 22 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_20_05.rst
> b/doc/guides/rel_notes/release_20_05.rst
> index 2190eaf85..f0efc5295 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -56,6 +56,13 @@ New Features
> Also, make sure to start the actual text at the margin.
> =========================================================
>
> +* **Updated Intel i40e driver.**
> +
> + Updated i40e PMD with new features and improvements, including:
> +
> + * enable only dst MAC address as FDIR input set for ipv4-other
> + * enable both src MAC address and dst MAC address as FDIR input set
> + for ipv4-other
> +
>
Same here.
> Removed Items
> -------------
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 9fbda1c34..d11df8d83 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -9373,6 +9373,7 @@ i40e_get_valid_input_set(enum i40e_filter_pctype
> pctype,
> I40E_INSET_SRC_PORT | I40E_INSET_DST_PORT |
> I40E_INSET_SCTP_VT,
> [I40E_FILTER_PCTYPE_NONF_IPV4_OTHER] =
> + I40E_INSET_DMAC | I40E_INSET_SMAC |
> I40E_INSET_VLAN_OUTER | I40E_INSET_VLAN_INNER |
> I40E_INSET_IPV4_SRC | I40E_INSET_IPV4_DST |
> I40E_INSET_IPV4_TOS | I40E_INSET_IPV4_PROTO | diff --git
> a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h index
> aac89de91..e8b98b67e 100644
> --- a/drivers/net/i40e/i40e_ethdev.h
> +++ b/drivers/net/i40e/i40e_ethdev.h
> @@ -544,12 +544,19 @@ struct i40e_ipv6_l2tpv3oip_flow {
> uint32_t session_id; /* Session ID in big endian. */ };
>
> +/* A structure used to define the input for l2 dst type flow */ struct
l2 dst type flow?
> +i40e_eth_l2_flow {
Flow other names, use i40e_l2_flow here.
> + struct rte_ether_addr dst;
> + struct rte_ether_addr src;
> + uint16_t ether_type; /**< Ether type in big endian */
> +};
> +
> /*
> * A union contains the inputs for all types of flow
> * items in flows need to be in big endian
> */
> union i40e_fdir_flow {
> - struct rte_eth_l2_flow l2_flow;
> + struct i40e_eth_l2_flow l2_flow;
> struct rte_eth_udpv4_flow udp4_flow;
> struct rte_eth_tcpv4_flow tcp4_flow;
> struct rte_eth_sctpv4_flow sctp4_flow;
> @@ -628,6 +635,13 @@ struct i40e_fdir_action {
> uint8_t flex_off;
> };
>
> +/* Ether input set kinds */
> +enum i40e_fdir_eth_inset {
> + I40E_ETH_INSET_NULL = 0,
> + I40E_ETH_INSET_DMAC,
> + I40E_ETH_INSET_SMAC_DMAC,
> +};
What's the enumeration's purpose?
Could you follow the original code for input set configuration and packet
construct?
