2015-02-19 10:14, Jastrzebski, MichalX K: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-02-19 09:18, Jastrzebski, MichalX K: > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > > 2015-02-13 16:12, Declan Doherty: > > > > > On 13/02/15 15:16, Michal Jastrzebski wrote: > > > > > > Michal Jastrzebski (6): > > > > > > net: changed arp_hdr struct declaration > > > > > > bond: add link bonding mode 6 implementation > > > > > > bond: add debug info for mode 6 link bonding > > > > > > bond: add example application for link bonding mode 6 > > > > > > bond: modify TLB unit tests > > > > > > bond: add unit tests for link bonding mode 6. > > > > > > > Hi Thomas, > > > > You didn't sign some of these patches. So I suspect that you should > > > > fix some authorship. > > > That's because I am not an author of all of these patches - 1/6, 5/6 and > > > 6/6 > > > > You probably broke it by importing patches with "patch" command instead of > > "git am". > > Then you must fix the authorship in your git tree before sending. > > The authorship in v2 is proper as I think I shouldn't signoff patch that is > not mine > - that I was never working on the code it provides, should I?
No. Signed-off is about responsibility of a patch. I'm speaking about authorship. Please use "git log" and check what is the name after "Author: ". There is also authoring date but it's not important. When sending email, the Author field is converted in a From field. > I edited the patches manually before I submitted it to match the proper > authority, > In git tree I have all patches signed-off by myself by default.
