On 3/19/20, 5:54 AM, "David Marchand" <david.march...@redhat.com> wrote:
On Tue, Mar 10, 2020 at 10:32 AM Bruce Richardson
<bruce.richard...@intel.com> wrote:
>
> On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote:
> > If contigmem is not able to allocate all of the
> > requested buffers, it frees whatever buffers were
> > able to be allocated up until that point.
> >
> > But the pointers are not set to NULL in that case.
> > After the load fails, the FreeBSD kernel will
> > immediately call the contigmem unload handler, which
> > tries to free the buffers again since the pointers
> > were not set to NULL.
> >
> > It's not clear that we should just rely on the unload
> > handler getting called after load failure. So let's
> > keep the existing cleanup code in the load handler,
> > but explicitly set the pointers to NULL after freeing
> > them.
Can you check this Fixes is correct?
Fixes: 5f51eca22489 ("contigmem: free allocated memory on error")
Cc: sta...@dpdk.org
Yes - that's correct. Thanks!
-Jim
