Hi David,
> Hello, > > On Thu, Feb 27, 2020 at 6:34 PM Laatz, Kevin <kevin.la...@intel.com> > wrote: > > > > > The ep struct is used to track what type of stats are required by the > client. > > > For PORT_STATS type, it contains the lists of port and metric ids to > > > query, and the number of ids in each list. > > > > > > The ep struct has values set (num of port and metric ids) when a > > > request for port stats values by name is received. However, after > > > this value assignment, the struct is reset to all 0 values, meaning > > > the number of port and metric ids required now both show as 0, and > > > the client will not receive the requested data in response. To fix > > > this issue, the memset call is now moved above the ep struct value > assignment. > > > > > > Fixes: 4080e46c8078 ("telemetry: support global metrics") > > > Cc: reshma.pat...@intel.com > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Ciara Power <ciara.po...@intel.com> > > > > Reviewed-by: Kevin Laatz <kevin.la...@intel.com> > > > > For the title, how about: > telemetry: fix port stats retrieval > > I can fix while applying. > > > -- > David Marchand That title change is okay with me, thanks. - Ciara