12/03/2020 04:31, Kalesh Anakkur Purayil: > On Wed, Mar 11, 2020 at 6:50 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > 22/01/2020 11:16, Kalesh A P: > > > From: Kalesh AP <kalesh-anakkur.pura...@broadcom.com> > > > > > > Adding support for recovery event in rte_eth_event framework. > > > FW error and FW reset conditions would be managed by PMD. > > > In such cases, PMD would need recovery events to notify application > > > about PMD has recovered from FW reset or FW error. > > > > > > Signed-off-by: Kalesh AP <kalesh-anakkur.pura...@broadcom.com> > > > Signed-off-by: Ajit Khaparde <ajit.khapa...@broadcom.com> > > > Reviewed-by: Somnath Kotur <somnath.ko...@broadcom.com> > > > --- > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > @@ -3015,6 +3015,7 @@ enum rte_eth_event_type { > > > RTE_ETH_EVENT_NEW, /**< port is probed */ > > > RTE_ETH_EVENT_DESTROY, /**< port is released */ > > > RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */ > > > + RTE_ETH_EVENT_RECOVERED, /**< port recovered from an error */ > > > > What the application is supposed to do when receiving such event? > > > [Kalesh]: RTE_ETH_EVENT_RECOVERED event is an indication to the > application that PMD has recovered from the reset and is functional > again(i.e control path and data path is up again). On receiving this event > from PMD, application has to re-create any flow rules created prior to the > reset.
How the application knows that flow rules were resetted? Is there any other configuration resetted? These informations must be explicit in the doxygen comments.