[dpdk-dev] [PATCH v8 04/19] eal: fix wrong strnlen() return value in 32bit icc

[Cunming Liang]

The problem is that strnlen() here may return invalid value with 32bit icc.
(actually it returns it?s second parameter,e.g: sysconf(_SC_ARG_MAX)).
It starts to manifest hwen max_len parameter is > 2M and using icc ?m32 ?O2 (or 
above).

Suggested-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
Signed-off-by: Cunming Liang <cunming.liang at intel.com>
---
 v8 changes:
   keep using strlen for trusted input string

 v7 changes:
   rollback to use strnlen

 v5 changes:
   using strlen instead of strnlen.

 lib/librte_eal/common/eal_common_options.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_options.c 
b/lib/librte_eal/common/eal_common_options.c
index 0b18c55..e227a6a 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -167,7 +167,7 @@ eal_parse_coremask(const char *coremask)
        if (coremask[0] == '0' && ((coremask[1] == 'x')
                || (coremask[1] == 'X')))
                coremask += 2;
-       i = strnlen(coremask, PATH_MAX);
+       i = strlen(coremask);
        while ((i > 0) && isblank(coremask[i - 1]))
                i--;
        if (i == 0)
@@ -227,7 +227,7 @@ eal_parse_corelist(const char *corelist)
        /* Remove all blank characters ahead and after */
        while (isblank(*corelist))
                corelist++;
-       i = strnlen(corelist, sysconf(_SC_ARG_MAX));
+       i = strlen(corelist);
        while ((i > 0) && isblank(corelist[i - 1]))
                i--;

@@ -472,7 +472,7 @@ eal_parse_lcores(const char *lcores)
        /* Remove all blank characters ahead and after */
        while (isblank(*lcores))
                lcores++;
-       i = strnlen(lcores, sysconf(_SC_ARG_MAX));
+       i = strlen(lcores);
        while ((i > 0) && isblank(lcores[i - 1]))
                i--;

-- 
1.8.1.4