On Mon, Feb 17, 2020 at 2:41 AM Xiaoyun Li <xiaoyun...@intel.com> wrote: > > Removed redundant function call of 'rte_eth_dev_info_get()' since it has > already been called earlier. > > Coverity issue: 349922 > Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com>
Little comment, this patch solves a coverity issue. Upon inspection of this example code, I can see no check on device capability when sending packets. So I suppose it is broken when user asks for TSO, but the devices do not support TSO. Can you investigate and fix this in the next release? Reviewed-by: Xiaolong Ye <xiaolong...@intel.com> Acked-by: David Marchand <david.march...@redhat.com> Applied, thanks. -- David Marchand