> -----Original Message----- > From: Markovic, Stevan [mailto:smarkovi at akamai.com] > Sent: Monday, February 16, 2015 3:22 PM > To: Ananyev, Konstantin; yuzhichang_scl at hotmail.com; dev at dpdk.org > Subject: Re: [dpdk-dev] ACL lookup doesn't work for some schemes > > Hi, > > > On 2/16/15, 4:56 AM, "Ananyev, Konstantin" <konstantin.ananyev at intel.com> > wrote: > > > > >Yes, right now, libtre_acl to work correctly first field has to be 1B > >long and all subsequent grouped into sets of 4 consecutive bytes. > >I thought we have it documented into our PG, ACL section: > >http://dpdk.org/doc/guides/prog_guide/packet_classif_access_ctrl.html > >Though re-reading it again: > >"For performance reasons, the inner loop of the search function is > >unrolled to process four input bytes at a time. This requires the input > >to be grouped into sets of 4 consecutive bytes. The loop processes the > >first input byte as part of the setup and then subsequent bytes must be > >in groups of 4 consecutive bytes." > >It probably not very clear and need to be explained in more details. > >Will update the doc. > > > >Konstantin > > > > While improving API documentation would be great, enforcing these > constraints on user defined fields in rte_acl_build(?) also (return an > error if constraints are not met) would be even better. > > Stevan
Good point. Will try to add some extra checks to rte_acl_build(). If time permits - for 2.0 timeframe, if not then for 2.1. Konstantin
