On 2/6/2020 7:14 PM, Pallavi Kadam wrote: > This patchset includes additional functionalities for Windows EAL > to support command-line parsing feature and some EAL common code > on Windows. > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > v8 changes: > Fixed the naming conventions. > Fixed a crash encountered due to getopt function. > Removed "--syslog" from help options for Windows. > > v7 changes: > Removed Windows "eal_filesystem.h" for now and will be added > later if required. Currently, Windows EAL uses common version > of eal_filesystem.h. > > v6 changes: > Removed sysfs function as it was not required on Windows. > Removed syslog and dlfcn support for Windows. > > v5 changes: > Fixed indentation in patch 6. > > v4 changes: > Modified license/exceptions.txt file. > The following files in this patch-set require license exceptions as > listed: > dirent.h MIT license > getopt.h BSD-2-Clause license > getopt.c ISC and BSD-2-Clause license > > Removed syslog file in Windows and added ifndef Windows around syslog > classification parameters in the common code. > > v3 Changes: > Modified generic rte_vect to add Windows support. > Moved RTE_CPU* definitions to OS specific file. > Added SPDX tag on top of third party files. > > v2 Changes: > syslog.h: Replaced the BSD license boilerplate to SPDX tag. > > > Pallavi Kadam (9): > license: add license exception for windows > eal: dirent.h implementation for windows > eal: add additional function overrides in windows header files > eal: getopt implementation for windows > eal: add function to detect process type > eal: include SSE4 support for windows > eal: remove syslog and dlfcn support for windows > build: add additional common files support > eal: add minimum viable code to support parsing > > lib/librte_eal/common/eal_common_options.c | 14 + > .../common/include/arch/x86/rte_vect.h | 4 +- > lib/librte_eal/windows/eal/eal.c | 194 ++++- > lib/librte_eal/windows/eal/eal_debug.c | 1 + > lib/librte_eal/windows/eal/eal_lcore.c | 3 + > lib/librte_eal/windows/eal/eal_thread.c | 11 + > lib/librte_eal/windows/eal/getopt.c | 470 +++++++++++++ > lib/librte_eal/windows/eal/include/dirent.h | 664 ++++++++++++++++++ > lib/librte_eal/windows/eal/include/getopt.h | 92 +++ > lib/librte_eal/windows/eal/include/pthread.h | 66 ++ > lib/librte_eal/windows/eal/include/rte_os.h | 42 ++ > lib/librte_eal/windows/eal/include/sched.h | 46 ++ > .../windows/eal/include/sys/queue.h | 8 + > lib/librte_eal/windows/eal/meson.build | 9 +- > license/exceptions.txt | 12 +- > 15 files changed, 1625 insertions(+), 11 deletions(-) > create mode 100644 lib/librte_eal/windows/eal/getopt.c > create mode 100644 lib/librte_eal/windows/eal/include/dirent.h > create mode 100644 lib/librte_eal/windows/eal/include/getopt.h > Tested-by: Narcisa Vasile <navas...@microsoft.com>
Acked-by: Narcisa Vasile <navas...@microsoft.com>