> We are working on a patch, when it is ready we will send it. > If it's not ready by end of your today, of course, go ahead with (b) and > we will work towards 20.05.
We will not be sending a patch today. The patch we're working on will provide two versions of rte_cryptodev_info_get(), both call the same PMD function from the dev_ops info_get fn ptr. The default version operates s as normal, the 19.11 version searches through the list returned by the PMD, looking for sym.aead.algo = ChaChaPoly, it needs to strip it from the list. As PMDs just pass a ptr to their capabilities list ( it isn't a linked list, but an array with an end marker = RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST) if the API layer detects Chacha it must allocate some space and store a local copy of the trimmed list. This must be stored only once per device. This versioning will apply to any PMD which wants to take advantage of the new API between now and 20.11. Note, I expect the ABI checker tools will still complain of ABI breakage as the LIST_END value will still change. We are also reviewing all other cryptodev APIs in case there is any other API which needs versioning. Anyone see any problem with this approach?
