04/02/2020 12:48, Bruce Richardson:
> as we discussed offline, I really don't like the necessity of the
> hidden_deps part of this, so I've tried coming up with some other
> solutions.
Thanks for looking closely at these patches.
> For example, in my testing I get the same result with the
> following diff instead of the second two patches (just showing for mlx5 -
> changes for mlx4 are identical):
[...]
> - # Build without adding shared libs to Requires.private
> - hidden_deps +=
> lib.partial_dependency(compile_args:true)
[...]
> + ibv_cflags = run_command(find_program('pkg-config'), '--cflags',
> 'libibverbs').stdout()
[...]
> By doing things this way - assuming it works in your tests too - we avoid
> any need to change anything in the common drivers code.
Yes, you hide the dependency by getting cflags directly with pkg-config.
I wanted to avoid such solution because I was trying to use as much
as possible the meson infrastructure.
I think your solution relying on one more call to pkg-config is acceptable.
I will test it and will review whether we get all corner cases.
In the meantime I discovered we are overlinking with meson
when using the dlopen linking option.
I will try to fix it as well with the same method.
Thanks
