Re: [dpdk-dev] [PATCH v4 2/8] crypto/aesni_gcm: cpu crypto support

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Smoczynski, MarcinX <marcinx.smoczyn...@intel.com>
> Sent: Tuesday, January 28, 2020 3:17 AM
> To: akhil.go...@nxp.com; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>;
> Doherty, Declan <declan.dohe...@intel.com>; Nicolau, Radu
> <radu.nico...@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>
> Cc: dev@dpdk.org; Smoczynski, MarcinX <marcinx.smoczyn...@intel.com>
> Subject: [PATCH v4 2/8] crypto/aesni_gcm: cpu crypto support
> 
> Add support for CPU crypto mode by introducing required handler.
> Crypto mode (sync/async) is chosen during sym session create if an appropriate
> flag is set in an xform type number.
> 
> Authenticated encryption and decryption are supported with tag
> generation/verification.
> 
> Signed-off-by: Marcin Smoczynski <marcinx.smoczyn...@intel.com>

...

> @@ -331,9 +331,12 @@ struct rte_cryptodev_ops aesni_gcm_pmd_ops = {
>               .queue_pair_release     = aesni_gcm_pmd_qp_release,
>               .queue_pair_count       = aesni_gcm_pmd_qp_count,
> 
> +             .sym_cpu_process        = aesni_gcm_pmd_cpu_crypto_process,
> +
>               .sym_session_get_size   =
> aesni_gcm_pmd_sym_session_get_size,
>               .sym_session_configure  =
> aesni_gcm_pmd_sym_session_configure,
>               .sym_session_clear      = aesni_gcm_pmd_sym_session_clear
>  };
> 
>  struct rte_cryptodev_ops *rte_aesni_gcm_pmd_ops = &aesni_gcm_pmd_ops;
> +

Minor thing, but you should remove this blank line.

Apart from that:

Acked-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>