On 1/23/2020 6:20 PM, Alexander Kozyrev wrote: > Remove -Werror-all flag in ICC configuration file to stop treating ICC > warnings as errors in DPDK due to many false positives. We are using > GCC and Clang as a benchmark for warnings anyway for simplification. > > Suggested-by: Thomas Monjalon <tho...@monjalon.net> > Signed-off-by: Alexander Kozyrev <akozy...@mellanox.com> > Acked-by: Viacheslav Ovsiienko <viachesl...@mellanox.com> > Acked-by: Thomas Monjalon <tho...@monjalon.net> > --- > mk/toolchain/icc/rte.vars.mk | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk > index 8aa87aa..1729f3d 100644 > --- a/mk/toolchain/icc/rte.vars.mk > +++ b/mk/toolchain/icc/rte.vars.mk > @@ -47,10 +47,6 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527 > WERROR_FLAGS += -diag-disable 188 > WERROR_FLAGS += -diag-disable 11074 -diag-disable 11076 -Wdeprecated > > -ifeq ($(RTE_DEVEL_BUILD),y) > -WERROR_FLAGS += -Werror-all > -endif > -
Not sure about removing this globally, as of now the ICC builds fine. If this is for the coming changes in mlx, why not disable warnings in mlx driver only?
