> -----Original Message-----
> From: Dekel Peled <[email protected]>
> Sent: Wednesday, January 22, 2020 16:27
> To: Matan Azrad <[email protected]>; Slava Ovsiienko
> <[email protected]>
> Cc: Raslan Darawsheh <[email protected]>; Ori Kam
> <[email protected]>; [email protected]; [email protected]
> Subject: [PATCH 06/11] net/mlx5: fix block push VLAN action on Rx
>
> Add missing check in validation function of 'push VLAN' action.
> Action is not allowed for ingress flow rules.
>
> Fixes: 9aee7a8418d4 ("net/mlx5: support push flow action on VLAN header")
> Cc: [email protected]
>
> Signed-off-by: Dekel Peled <[email protected]>
> Acked-by: Ori Kam <[email protected]>
Acked-by: Viacheslav Ovsiienko <[email protected]>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index b0d5688..1ed677f 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1741,6 +1741,12 @@ struct field_modify_info modify_tcp[] = { {
> const struct rte_flow_action_of_push_vlan *push_vlan = action->conf;
>
> + if (attr->ingress)
> + return rte_flow_error_set(error, ENOTSUP,
> +
> RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
> + NULL,
> + "push VLAN action not supported for
> "
> + "ingress");
> if (push_vlan->ethertype != RTE_BE16(RTE_ETHER_TYPE_VLAN) &&
> push_vlan->ethertype != RTE_BE16(RTE_ETHER_TYPE_QINQ))
> return rte_flow_error_set(error, EINVAL,
> --
> 1.8.3.1
