20/01/2020 14:54, Mcnamara, John: > From: stable <stable-boun...@dpdk.org> On Behalf Of Thomas Monjalon > > 15/01/2020 16:54, Akhil Goyal: > > > > > > > > > > This patch replaces existing test vector with a new one containing > > > > > C code to fix license issue. > > > > > > > > > > Signed-off-by: Artur Trybula <arturx.tryb...@intel.com> > > > > Acked-by: Fiona Trahe <fiona.tr...@intel.com> > > > Applied to dpdk-next-crypto > > > > This is a terrible idea. > > Adding C code in a C project as text, and worst, its own code, will make > > grep matching on fake text. > > Hi, > > I don't think this is a valid criticism. The patch replace code in Pascal > with some code in C as a compression test. The grep part isn't really > relevant, it should be clear to anyone who finds a match. > > If you have a strong objection we will replace it with some more public > domain text.
Yes please, it will be less confusing. > > Why do you need so much text to compress? Please why do we need some code at all? > > Why not just opening our own code files as text? > > That probably isn't worth the effort. > > > Why sta...@dpdk.org is Cc'ed in this email? > > Ok. We'll do that. I say Why? You say Ok :-) > > What is the license issue? > > The issue is that the Pascal code from the Calgary Corpus (a standard body of > compression test input) doesn't have a license or explicitly say that it is > in the public domain so it isn't clear if we can relicense it as BSD-3. We > are being overly cautious here but we didn't want to run into any potential > license issues. OK Please explain in the commit log.
