On 1/19/2020 3:53 PM, Alfredo Cardigliano wrote: > Add basic, per queue and extended statistics for > RX and TX, both from the adapter and the driver. > > Signed-off-by: Alfredo Cardigliano <cardigli...@ntop.org> > Reviewed-by: Shannon Nelson <snel...@pensando.io>
<...> > @@ -84,6 +84,153 @@ ionic_lif_reset(struct ionic_lif *lif) > ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT); > } > > +static void > +ionic_lif_get_abs_stats(struct ionic_lif *lif, struct rte_eth_stats *stats) > +{ This is causing build error [1] becaues the provided 'lif' argument by 'ionic_lif_get_stats()' to this fucntion is const. I can fix this while merging if this is the only issue. [1] .../drivers/net/ionic/ionic_lif.c: In function ‘ionic_lif_get_stats’: .../drivers/net/ionic/ionic_lif.c:184:26: error: passing argument 1 of ‘ionic_lif_get_abs_stats’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 184 | ionic_lif_get_abs_stats(lif, stats); | ^~~ .../drivers/net/ionic/ionic_lif.c:88:43: note: expected ‘struct ionic_lif *’ but argument is of type ‘const struct ionic_lif *’ 88 | ionic_lif_get_abs_stats(struct ionic_lif *lif, struct rte_eth_stats *stats) | ~~~~~~~~~~~~~~~~~~^~~