On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin <maxime.coque...@redhat.com> wrote: > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote: > > Ping. > > > > On Thu, Dec 12, 2019 at 6:42 PM <jer...@marvell.com> wrote: > >> > >> From: Jerin Jacob <jer...@marvell.com> > >> > >> Based on the techboard meeting held on 2019-11-06, > >> It's been decided to disable all kmods by default from v20.02. > >> > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html > >> > >> Signed-off-by: Jerin Jacob <jer...@marvell.com> > >> --- > >> config/common_linux | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/config/common_linux b/config/common_linux > >> index c5cf3d662..583efadc7 100644 > >> --- a/config/common_linux > >> +++ b/config/common_linux > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y > >> > >> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y > >> -CONFIG_RTE_EAL_IGB_UIO=y > >> CONFIG_RTE_EAL_VFIO=y > >> -CONFIG_RTE_KNI_KMOD=y > >> CONFIG_RTE_LIBRTE_KNI=y > >> CONFIG_RTE_LIBRTE_PMD_KNI=y > >> CONFIG_RTE_LIBRTE_VHOST=y > >> -- > >> 2.24.0 > >> > > > > Looks good for make build system, but what about Meson? > as per meson_options.txt, isn't it enabled by default? > $ grep -rn enable_kmods meson_options.txt > 7:option('enable_kmods', type: 'boolean', value: true,
+ Bruce, Since meson autodetect the presence of Linux kernel dependency for the kmod build, I thought of keeping as it is as there is no harm. I am fine with either way, let me the know the feedback, I will send the v2 based on the comment. > > Thanks, > Maxime >
