Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh <ferruh.yi...@intel.com> > Sent: Wednesday, January 15, 2020 4:18 PM > To: Iremonger, Bernard <bernard.iremon...@intel.com>; dev@dpdk.org; > Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; > Doherty, Declan <declan.dohe...@intel.com> > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; Byrne, Stephen1 > <stephen1.by...@intel.com>; Zhang, Helin <helin.zh...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v6 10/13] config: add debug to I40E Flow > Director > > On 1/15/2020 3:53 PM, Bernard Iremonger wrote: > > add CONFIG_RTE_LIBRTE_I40E_DEBUG_FD to config/common_base file > > > > Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com> > > --- > > config/common_base | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/config/common_base b/config/common_base index > > 7dec7ed..7a76c26 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -305,6 +305,7 @@ CONFIG_RTE_LIBRTE_I40E_PMD=y > > CONFIG_RTE_LIBRTE_I40E_DEBUG_RX=n > CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n > > CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n > > +CONFIG_RTE_LIBRTE_I40E_DEBUG_FD=y > > CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y > > CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y > > CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n > > > > Hi Bernard, > > If the dynamic log won't make in time, what do you think dropping the > RTE_LIBRTE_I40E_DEBUG_FD patches for now, it seems it is only for debug, > and do the dynamic log support incremental later?
I have had a look at the existing rte_log() support in the i40e code in i40e_logs.h and i40e_ethdev.c (line 403 +) and lines 12930 + The RTE_LIBRTE_I40E_DEBUG_XXX macros are used so this change to config/common_base is needed for dynamic logging too. The PMD_RX_LOG() seems to only do a printf () which is not what I want. I would like to keep these two patches which have been acked in the v5 patchset. I will continue with the dynamic logging after the merge if that is allowed. Regards, Bernard
