Re: [dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel

[Iremonger, Bernard]

Hi Qi,

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zh...@intel.com>
> Sent: Thursday, January 9, 2020 2:09 PM
> To: Iremonger, Bernard <bernard.iremon...@intel.com>; dev@dpdk.org;
> Xing, Beilei <beilei.x...@intel.com>; Doherty, Declan
> <declan.dohe...@intel.com>
> Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; Byrne, Stephen1
> <stephen1.by...@intel.com>; Zhang, Helin <helin.zh...@intel.com>
> Subject: RE: [PATCH v3 4/9] net/i40e: handle ESP tunnel
> 
> Hi Bernard:
> > -----Original Message-----
> > From: Iremonger, Bernard <bernard.iremon...@intel.com>
> > Sent: Thursday, January 9, 2020 8:16 PM
> > To: dev@dpdk.org; Xing, Beilei <beilei.x...@intel.com>; Zhang, Qi Z
> > <qi.z.zh...@intel.com>; Doherty, Declan <declan.dohe...@intel.com>
> > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; Byrne,
> > Stephen1 <stephen1.by...@intel.com>; Zhang, Helin
> > <helin.zh...@intel.com>; Iremonger, Bernard
> > <bernard.iremon...@intel.com>
> > Subject: [PATCH v3 4/9] net/i40e: handle ESP tunnel
> >
> > handle ESP tunnel in rte_pmd_i40e.c
> 
>       Not sure if this should be part of the patch that enable the DDP that
> support ESP packet type, or at least it should be the one after that patch?

I think it is ok to be in a separate patch (easier to review).
The patch set may need to be reordered.

> 
> Regards
> Qi
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com>
> > ---
> >  drivers/net/i40e/rte_pmd_i40e.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> > b/drivers/net/i40e/rte_pmd_i40e.c index fdcb1a4..b987346 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e.c
> > +++ b/drivers/net/i40e/rte_pmd_i40e.c
> > @@ -2172,7 +2172,8 @@ static int check_invalid_pkt_type(uint32_t
> pkt_type)
> >         tnl != RTE_PTYPE_TUNNEL_GRENAT &&
> >         tnl != RTE_PTYPE_TUNNEL_GTPC &&
> >         tnl != RTE_PTYPE_TUNNEL_GTPU &&
> > -       tnl != RTE_PTYPE_TUNNEL_L2TP)
> > +       tnl != RTE_PTYPE_TUNNEL_L2TP &&
> > +       tnl != RTE_PTYPE_TUNNEL_ESP)
> >             return -1;
> >
> >     if (il2 &&
> > --
> > 2.7.4
> 

Thanks for review.

Regards,

Bernard.