On Tue, Jan 7, 2020 at 1:18 AM Ferruh Yigit <ferruh.yi...@intel.com> wrote:
> On 1/7/2020 12:37 AM, Ajit Khaparde wrote:
> > In some cases when flow creation fails, we overwrite the specific
> > error message with a generic error message. This patch fixes it.
> >
> > Fixes: d24610f7bfda ("net/bnxt: allow flow creation when RSS is enabled")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
> > Reviewed-by: Lance Richardson <lance.richard...@broadcom.com>
> > ---
> > drivers/net/bnxt/bnxt_flow.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> > index 707aedcec..cde1fa41c 100644
> > --- a/drivers/net/bnxt/bnxt_flow.c
> > +++ b/drivers/net/bnxt/bnxt_flow.c
> > @@ -1485,7 +1485,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev
> *dev,
> > if (rxq && !vnic->rx_queue_cnt)
> > rxq->vnic = &bp->vnic_info[0];
> > }
> > - return rc;
> > + return -rte_errno;
>
> The result will be same as far as I can see, you may get rid of the "rc =
> -rte_errno;" assignments before "goto ret;" with this change if you want.
>
I had that change lined up for my next set. But I can send it early.
>
> Also commit log seems describing the below change not this one ...
>
> > }
> >
> > static
> > @@ -1815,7 +1815,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
> > rte_flow_error_set(error, 0,
> > RTE_FLOW_ERROR_TYPE_NONE, NULL,
> > "Flow with pattern exists, updating
> destination queue");
> > - else
> > + else if (!rte_errno)
> > rte_flow_error_set(error, -ret,
> > RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
> > "Failed to create flow.");
> >
>
>
