> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Friday, December 20, 2019 4:45 AM > > On Fri, Dec 20, 2019 at 8:56 AM Gavin Hu <gavin...@arm.com> wrote: > > > > Hi Jerin, > > > > It got two coding style warnings, otherwise, > > Reviewed-by: Gavin Hu <gavin...@arm.com> > > Thanks Gavin for review. Since the existing code is using "unsigned" > in that file, I thought of not change by this patch. > If someone thinks, It is better to change then I can send v2 by fixing > "unsigned" to "unsigned int" across the file as a first patch in the > series. >
The use of the type "unsigned" is a general issue with older DPDK libraries. Anyone touching any of these libraries will get these warnings. They should all be fixed. I'm not saying you should do it; I'm only suggesting that someone should create a dedicated patch to fix them all. > > > > WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of > 'unsigned' > > #144: FILE: lib/librte_mempool/rte_mempool.c:84: > > +arch_mem_object_align(unsigned obj_size) > > > > WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of > 'unsigned' > > #154: FILE: lib/librte_mempool/rte_mempool.c:106: > > +arch_mem_object_align(unsigned obj_size)
