On Wed, Dec 18, 2019 at 11:58:31AM +0000, Reshma Pattan wrote:
> Some unit tests has dependency on RING PMD,
> so this patch is trying to fix those and other
> closely related issues.
>
> 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter
> unit tests are dependent on ring PMD, so compile those
> tests only when ring PMD is enabled else ignore.
>
> 2)get rid of make file error which was added by bond unit test
> for ring PMD disabled case which is not necessary.
>
> 3)Tx adapter UT is dependent on RING PMD, but it was
> observed that it was missing from the run in meson
> build, so added it. TX adapter UT uses 'sw event and
> 'null' pmd drivers, so for shared builds the drivers .so
> path has to be passed to the test args of meson UT run.
>
> Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library")
> Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library")
> Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats library")
> Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter")
> Fixes: d23e09e0ef ("app/test: link with ring pmd when needed")
>
> CC: sta...@dpdk.org
> CC: Nikhil Rao <nikhil....@intel.com>
> CC: Chas Williams <ch...@att.com>
> CC: Bruce Richardson <bruce.richard...@intel.com>
> CC: Stephen Hemminger <step...@networkplumber.org>
>
> Reported-by: Stephen Hemminger <step...@networkplumber.org>
> Signed-off-by: Reshma Pattan <reshma.pat...@intel.com>
> ---
> v4: fix event_eth_tx_adapter_autotest for shared build
> as reported by travis-ci
> https://travis-ci.com/ovsrobot/dpdk/jobs/249598391
> v3: add missing test event_eth_tx_adapter_autotest.
> Add link bonding mode4 test to drivers test.
> v2: fix comments of v1 and combine the patches 1/2 and 2/2 of v1
> ---
> app/test/Makefile | 16 +++++-----------
> app/test/meson.build | 37 +++++++++++++++++++++++--------------
> app/test/process.h | 8 ++++++++
> app/test/test.c | 2 ++
> 4 files changed, 38 insertions(+), 25 deletions(-)
>
<snip>
>
> test_args = [num_cores_arg]
> +
> +
One blank line is probably enough.
> foreach arg : fast_test_names
> + if (get_option('default_library') == 'shared' and
> + arg == 'event_eth_tx_adapter_autotest')
> + foreach drv:dpdk_drivers
> + test_args += ['-d', drv.full_path().split('.a')[0] +
> '.so']
> + endforeach
> + endif
Does this need to be limited to just this one test? Why not just set the
test args outside the loop to always include all drivers if it is a shared
build?
/Bruce
