On Thu, Dec 12, 2019 at 3:05 PM Xiaojun Liu <[email protected]> wrote: > > This is not a generic i2c bus, but rather an indirect access to i2c devices > through FM10k registers. It's only purpose is to support the fm10k chip. Also > there's currently no i2c bus support framework in DPDK.
To understand it better: # Who are the i2c master and i2c slave here? # Is i2c slave connected on board or in-built to FM10K SoC? # What is the purpose of the i2c API in the ethdev driver? > > -----Original Message----- > From: Jerin Jacob [mailto:[email protected]] > Sent: Wednesday, December 11, 2019 11:48 PM > To: Xiaojun Liu > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected] > Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/fm10k: add i2c sbus registers > definition > > On Wed, Dec 11, 2019 at 3:22 PM Xiaojun Liu <[email protected]> wrote: > > > > To support switch management, add the following files: > > Add fm10k/switch/fm10k_debug.h(define log Macros). > > Add fm10k/switch/fm10k_regs.h(define all the registers). > > Add fm10k/switch/fm10k_switch.h(define switch Macros and APIs). > > Add fm10k/switch/fm10k_i2c.h(define I2C interfaces). > > Add fm10k/switch/fm10k_i2c.c(support I2C access). > > Add fm10k/switch/fm10k_sbus.h(define SBUS interface). > > Add fm10k/switch/fm10k_sbus.c(support SBUS access). > > and modify fm10k/Makefile(add ENABLE_FM10K_MANAGEMENT support, > > add fm10k_i2c.c and fm10k_sbus.c). > > Integrating NIC with the integrated or onboard switches over i2c or > sbus is a common problem. > Instead of polluting ethdev driver with i2c and sbus _bus_ code, Why > not add new i2c bus > and move this code to driver/bus/i2c/xxxx/ > > > > > To avoid configuration for both kernel driver > > and userspace SDK outside DPDK, we add switch > > management in FM10K DPDK PMD driver. > > To enable switch management, you need add > > CONFIG_RTE_FM10K_MANAGEMENT=y in > > config/common_linux when building. > > > > Signed-off-by: Xiaojun Liu <[email protected]>
