Hi, > if algo is NULL set the status to error and return.
As this is a bug fix please add 'fix' to the commit header: examples/ipsec-secgw: fix ... Also probably worth to add 1-2 line explanation why this is needed into the commit message. Apart from that: Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > Signed-off-by: Savinay Dharmappa <savinay.dharma...@intel.com> > --- > examples/ipsec-secgw/sa.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > index 7f046e3ed..c75a5a15f 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -314,6 +314,9 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > APP_CHECK(algo != NULL, status, "unrecognized " > "input \"%s\"", tokens[ti]); > > + if (status->status < 0) > + return; > + > rule->cipher_algo = algo->algo; > rule->block_size = algo->block_size; > rule->iv_len = algo->iv_len; > @@ -378,6 +381,9 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > APP_CHECK(algo != NULL, status, "unrecognized " > "input \"%s\"", tokens[ti]); > > + if (status->status < 0) > + return; > + > rule->auth_algo = algo->algo; > rule->auth_key_len = algo->key_len; > rule->digest_len = algo->digest_len; > @@ -433,6 +439,9 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > APP_CHECK(algo != NULL, status, "unrecognized " > "input \"%s\"", tokens[ti]); > > + if (status->status < 0) > + return; > + > rule->aead_algo = algo->algo; > rule->cipher_key_len = algo->key_len; > rule->digest_len = algo->digest_len; > -- > 2.17.1
