On Mon, Dec 09, 2019 at 06:37:56AM +0000, Gargi Sau wrote:
> This checks the return value from the function
> rte_eth_dev_set_vlan_offload.
>
> Coverity issue: 350358
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample
> application")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Gargi Sau <gargi....@intel.com>
> ---
> examples/ethtool/lib/rte_ethtool.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/examples/ethtool/lib/rte_ethtool.c
> b/examples/ethtool/lib/rte_ethtool.c
> index 667d7eaf2..db8150efd 100644
> --- a/examples/ethtool/lib/rte_ethtool.c
> +++ b/examples/ethtool/lib/rte_ethtool.c
> @@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)
> }
>
> /* Enable Rx vlan filter, VF unspport status is discard */
> - rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> + ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> + if (ret != 0)
> + return ret;
>
Looks ok to me.
Acked-by: Bruce Richardson <bruce.richard...@intel.com>
