> -----Original Message-----
> From: Aaron Conole <acon...@redhat.com>
> Sent: Tuesday, November 26, 2019 8:56 AM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haa...@intel.com>; Richardson, Bruce
> <bruce.richard...@intel.com>; Pavan Nikhilesh
> <pbhagavat...@marvell.com>; Eads, Gage <gage.e...@intel.com>; Thomas
> Monjalon <tho...@monjalon.net>; David Marchand
> <dmarc...@redhat.com>
> Subject: [PATCH] service: don't walk out of bounds when checking services
>
> The service_valid call is used without properly bounds checking the input
> parameter. Almost all instances of the service_valid call are inside a for()
> loop that prevents excessive walks, but some of the public APIs don't bounds
> check and will pass invalid arguments.
>
> Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, and
> adding a bounds check to one service_valid() use.
>
> Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function")
> Fixes: e9139a32f6e8 ("service: add function to run on app lcore")
> Fixes: e30dd31847d2 ("service: add mechanism for quiescing")
> Signed-off-by: Aaron Conole <acon...@redhat.com>
Acked-by: Gage Eads <gage.e...@intel.com>
Thanks,
Gage
