On Fri, Nov 22, 2019 at 5:29 PM Thomas Monjalon <tho...@monjalon.net> wrote:
>
> 22/11/2019 16:54, David Marchand:
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > +if [ "$AARCH64" != "1" ]; then
> > +    ./devtools/test-null.sh
>
> You are missing the build directory as first parameter,
> otherwise it won't find testpmd.

This parameter is optional.
In test-null.sh:
build=${1:-build} # first argument can be the build directory

travis builds in this directory.

I suppose you noticed that the jobs in travis were all failing, but
this is because the fix [1] on testpmd is not in master yet.
1: https://patchwork.dpdk.org/patch/63226/


>
> One nit: ./ is probably useless.

No strong opinion.


-- 
David Marchand

Reply via email to