22/11/2019 13:24, Ferruh Yigit: > On 11/22/2019 10:43 AM, David Marchand wrote: > > diff --git a/devtools/test-null.sh b/devtools/test-null.sh > > index 9f9a459f76..6e5b1ad529 100755 > > --- a/devtools/test-null.sh > > +++ b/devtools/test-null.sh > > @@ -25,6 +25,6 @@ else > > fi > > > > (sleep 1 && echo stop) | > > -$testpmd -c $coremask --no-huge -m 150 \ > > +$testpmd -c $coremask --no-huge -m 20 \ > > $libs --vdev net_null1 --vdev net_null2 $eal_options -- \ > > --no-mlockall --total-num-mbufs=2048 $testpmd_options -ia > > What do you think to separate this part, and go with first version of the > patchset? > > And I am not sure if we should update at all, what is the benefit?
The benefit it to test that there is no anormal memory needs. > Also script fails after update, because of the additional physical devices and > their memory requirement, it is possible to make it run with additional > testpmd > argument but fails by default. This test is supposed to be for null devices only. Why are you trying to add physical devices? Oh wait, we miss an option -w 0 to be in whitelist mode?
