On 20-Nov-19 1:25 PM, David Marchand wrote:
On Wed, Nov 20, 2019 at 3:12 AM Xueming(Steven) Li
<xuemi...@mellanox.com> wrote:
-----Original Message-----
From: David Marchand <david.march...@redhat.com>
Sent: Wednesday, November 20, 2019 4:47 AM
To: Xueming(Steven) Li <xuemi...@mellanox.com>; Anatoly Burakov
<anatoly.bura...@intel.com>
Cc: Asaf Penso <as...@mellanox.com>; dev <dev@dpdk.org>; dpdk stable
<sta...@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element
size
On Tue, Nov 12, 2019 at 3:50 PM Xueming Li <xuemi...@mellanox.com>
wrote:
When resize a memory with next element, the original element size grows.
If the orginal element has padding, the real inner element size didn't
grow as well and this causes trailer verification failure when malloc
debug enabled.
I did not see this when running the malloc_autotest with debug enabled.
What is missing for me to catch it?
Yes, it happens rarely, depends on memory fragment. I only caught this in
middle of a long test.
Just a bit chilly to apply this series.
The first patch seems an optimisation.
The second one seems more interesting if we fix the debug mode, but I
suppose we can live without them in 19.11.
Few people enable memory debug option, they are there for years.
Had a discussion offlist with Anatoly.
Those two issues are hard to catch but the fixes are relevant and
Anatoly is confident.
I will take this in rc3.
Series applied, thanks.
To test them, i had to modify malloc to always create padded elements :)
--
Thanks,
Anatoly
