On Tue, Nov 19, 2019 at 10:56 PM Kevin Traynor <ktray...@redhat.com> wrote: > > On 19/11/2019 21:18, David Marchand wrote: > > On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor <ktray...@redhat.com> wrote: > >> > >> Fix these as they are user visible. Found with codespell. > >> > >> Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > >> Fixes: f05e26051c15 ("eal: add IPC asynchronous request") > >> Fixes: 0cbce3a167f1 ("vfio: skip DMA map failure if already mapped") > >> Fixes: 445c6528b55f ("power: common interface for guest and host") > >> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > >> Fixes: 8f972312b8f4 ("vhost: support vhost-user") > >> Cc: sta...@dpdk.org > >> > >> Signed-off-by: Kevin Traynor <ktray...@redhat.com> > > > > For the series, > > Reviewed-by: David Marchand <david.march...@redhat.com> > > > > It would be nice to have codespell in devtools/checkpatches.sh. > > > > Voila!
"VoilĂ !" :-) > https://git.dpdk.org/dpdk/commit/devtools/checkpatches.sh?id=abdd314151b304eeab08528555e884544151a2e4 Arf, right. > Maybe we should add some doc to the contributors guide for it. It seems > to be run by one of the robots anyway. It is enabled by default. It does catch "informations". But it does not pick, for example, my typo on "preferrence" (no excuse, in French, it takes only one r too). Did you use https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary.txt ? Not sure the robots are using the latest version. -- David Marchand