On Fri, Nov 08, 2019 at 08:55:52PM +0100, Thomas Monjalon wrote:
> 08/11/2019 20:32, David Marchand:
> > The LTO job using gcc-7 has two issues at the moment:
> > - warnings about implicit fallthroughs trigger build errors:
> >
> > In file included from ...common/include/rte_memory.h:22:0,
> > from ...linux/eal/eal_hugepage_info.c:24:
> > ...common/include/rte_common.h: In function ‘rte_str_to_size’:
> > ...common/include/rte_common.h:744:27: error: this statement may
> > fall through [-Werror=implicit-fallthrough=]
> > case 'G': case 'g': size *= 1024; /* fall-through */
> > ~~~~~^~~~~~~
> >
> > - if we disable this warning, linking the binaries takes too much time
> > and the job is terminated by Travis because it reaches the maximum
> > time limit
> >
> > Fixes: 098cc0fea3be ("build: add option to enable LTO")
> >
> > Signed-off-by: David Marchand <david.march...@redhat.com>
>
> Acked-by: Thomas Monjalon <tho...@monjalon.net>
>
> Thank you, I should have tested it in Travis before merging.
>
I'm also interested in whether someone can give steps to reproduce this
issue outside of the Travis environment. I've tested with gcc-7 on both
Ubuntu 16.04 (as used by Travis) and Ubuntu 18.04, and the builds I tested
all worked fine, without any warnings being seen. I am therefore wondering
what is special about the travis setup that causes it to fail.
/Bruce
