Hi From: Ferruh Yigit > On 11/7/2019 12:35 PM, Dekel Peled wrote: > > This patch implements use of the API for LRO aggregated packet max > > size. > > It adds command-line and runtime commands to configure this value, and > > adds option to show the supported value. > > Documentation is updated accordingly. > > > > Signed-off-by: Dekel Peled <dek...@mellanox.com> > > <...> > > > +cmdline_parse_inst_t cmd_config_max_lro_pkt_size = { > > + .f = cmd_config_max_lro_pkt_size_parsed, > > + .data = NULL, > > + .help_str = "port config all max-lro-pkt-size <value>", > > Can you please update "cmd_help_long_parsed()" function to add this new > command to the help output? > > <...> > > > @@ -419,6 +419,7 @@ struct fwd_engine * fwd_engines[] = { struct > > rte_eth_rxmode rx_mode = { > > .max_rx_pkt_len = RTE_ETHER_MAX_LEN, > > /**< Default maximum frame length. */ > > + .max_lro_pkt_size = RTE_ETHER_MAX_LEN, > > If PMD value used if application doesn't provide a default value, my > comment on previous patch, we can remove this value. So > 'max_lro_pkt_size' can be used only set explicitly, otherwise used PMD > values.
Also here, should be the same behavior as for max_rx_pkt_len.