Can you provide more details on how this fixes the issue? Looking at the code,
the pointer *parser should get set by the code so I'm not sure how this change
does anything.
Paul
> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Simei Su
> Sent: Tuesday, November 5, 2019 11:09 PM
> To: Zhang, Qi Z <qi.z.zh...@intel.com>; Ye, Xiaolong <xiaolong...@intel.com>;
> Yang, Qiming <qiming.y...@intel.com>
> Cc: dev@dpdk.org; Su, Simei <simei...@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init
>
> This patch fixes core dump issue when entering safe mode with a wrong
> package file.
>
> Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>
> Signed-off-by: Simei Su <simei...@intel.com>
> ---
> drivers/net/ice/ice_hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index
> 3381b45..04ec30f 100644
> --- a/drivers/net/ice/ice_hash.c
> +++ b/drivers/net/ice/ice_hash.c
> @@ -236,7 +236,7 @@ struct ice_hash_match_type ice_hash_type_list[] = {
> static int ice_hash_init(struct ice_adapter *ad) {
> - struct ice_flow_parser *parser = NULL;
> + struct ice_flow_parser *parser;
>
> if (ad->active_pkg_type == ICE_PKG_TYPE_OS_DEFAULT)
> parser = &ice_hash_parser_os;
> --
> 1.8.3.1
