Hi Stephen, You are totally right about it, but, I needed this patch for some testing. So Will remove it from next-net-mlx for now, and will be waiting for some final version to be sent.
Kindest regards, Raslan Darawsheh > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Tuesday, November 5, 2019 7:27 PM > To: Raslan Darawsheh <rasl...@mellanox.com> > Cc: Bing Zhao <bi...@mellanox.com>; Ori Kam <or...@mellanox.com>; > Slava Ovsiienko <viachesl...@mellanox.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list > > On Tue, 5 Nov 2019 16:02:18 +0000 > Raslan Darawsheh <rasl...@mellanox.com> wrote: > > > Hi, > > > > > -----Original Message----- > > > From: Bing Zhao <bi...@mellanox.com> > > > Sent: Tuesday, November 5, 2019 5:28 PM > > > To: Ori Kam <or...@mellanox.com>; Slava Ovsiienko > > > <viachesl...@mellanox.com>; Raslan Darawsheh > <rasl...@mellanox.com>; > > > dev@dpdk.org > > > Subject: [PATCH] net/mlx5: introduce mlx5 hash list > > > > > > Introduce simple hash list to the mlx5 utilities. User can define > > > its own data structure containing the mlx5_hlist_entry and create > > > the hash list table via the creation interface. Then the entry will > > > be inserted into the table and linked to the corresponding list > > > head. User should guarantee there is no collision of the key and > > > provide a callback function to handle all the remaining entries in > > > the table when destroying the hash list. User should define a proper > > > number of the list heads in the table in order to get a better > > > performance. The LSB of the 'key' is used to calculate the index of the > head in the list heads array. > > > This implementation is not multi-threads safe right now. > > > > > > Signed-off-by: Bing Zhao <bi...@mellanox.com> > > > --- > > > > Patch applied to next-net-mlx, > > Please don't apply so fast! Not allowing a few days for review means that it > is > just getting rubber stamped and not allowing for any feedback.
