On Mon, Oct 28, 2019 at 4:56 PM Ali Alnubani <alia...@mellanox.com> wrote:
>
> OcteonTx was disabled for causing an internal compiler error on old gcc
> versions.
> See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers").
>
> The condition that was added later to apply disabling OcteonTx
> only on arm64 caused the condition to never be obeyed because it
> compares ["arm64"] to [arm64].
>
> This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH,
> because the former has the quotes removed, while the later doesn't.
>
> Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ali Alnubani <alia...@mellanox.com>Acked-by: Jerin Jacob <jer...@marvell.com> > --- > mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk > b/mk/toolchain/gcc/rte.toolchain-compat.mk > index ea40a11c0..00d6fd642 100644 > --- a/mk/toolchain/gcc/rte.toolchain-compat.mk > +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk > @@ -99,7 +99,7 @@ else > endif > > # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64 > - ifeq ($(CONFIG_RTE_ARCH), arm64) > + ifeq ($(RTE_ARCH), arm64) > ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo > 1), 1) > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d > CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d > -- > 2.23.0 >
