On Wed, Oct 30, 2019 at 10:40 AM Dekel Peled <dek...@mellanox.com> wrote: > > -----Original Message----- > > From: David Marchand <david.march...@redhat.com> > > Sent: Wednesday, October 30, 2019 11:03 AM > > To: Dekel Peled <dek...@mellanox.com> > > Cc: Matan Azrad <ma...@mellanox.com>; Slava Ovsiienko > > <viachesl...@mellanox.com>; Shahaf Shuler <shah...@mellanox.com>; Ori > > Kam <or...@mellanox.com>; dev <dev@dpdk.org> > > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line char > > in logs > > > > On Wed, Oct 30, 2019 at 9:45 AM Dekel Peled <dek...@mellanox.com> > > wrote: > > > > > > DRV_LOG macro is used to print log messages, one per line. > > > In several locations this macro is used with redundant '\n' character > > > at the end of the log message, causing blank lines between log lines. > > > > > > This patch removes the '\n' character where it is redundant. > > > > Missing Fixes: ? > > This patch is 'cosmetic', not functional.
Having empty lines as noise when debugging is a pain for my pov. But this is your driver, so fair enough. -- David Marchand
