> -----Original Message----- > From: Damjan Marion (damarion) <damar...@cisco.com> > Sent: Friday, October 25, 2019 2:14 PM > To: Thomas Monjalon <tho...@monjalon.net> > Cc: David Marchand <david.march...@redhat.com>; Anatoly Burakov > <anatoly.bura...@intel.com>; Shahaf Shuler <shah...@mellanox.com>; Ray > Kinsella <m...@ashroe.eu>; dev <dev@dpdk.org>; Neil Horman > <nhor...@tuxdriver.com>; John McNamara <john.mcnam...@intel.com>; > Marko Kovacevic <marko.kovace...@intel.com>; Bruce Richardson > <bruce.richard...@intel.com> > Subject: Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping > functions > > > > > On 25 Oct 2019, at 00:32, Thomas Monjalon <tho...@monjalon.net> > wrote: > > > > 24/10/2019 21:09, David Marchand: > >> On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov > >> <anatoly.bura...@intel.com> wrote: > >>> > >>> The rte_vfio_dma_map/unmap API's have been marked as deprecated > in > >>> release 19.05. Remove them. > >>> > >>> Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com> > >>> --- > >>> > >>> Notes: > >>> Although `rte_vfio_dma_map` et al. was marked as deprecated in our > documentation, > >>> it wasn't marked as __rte_deprecated in code. Should we still remove > it? > >> > >> I can see that vpp is still using this api. > >> I would prefer we get some ack from their side. > >> > >> Shahaf? > >> Ray? > >> > >> Do you guys have contact with VPP devs? > > > > +Cc Damjan > > Thanks for looping me in. If I remember correctly that was used only to get > mlx PMDs working. > We can remove that calls but then mlx PMDs will stop working unless there is > alternative solution. > > From my perspective it is not big issue as we already have native rdma based > mlx support, but i would expect that other people will complain. > > Is there alternative way to tell DPDK about DMA mapping?
Damjan I don't follow. Why would using the rte_dev_dma_map would break Mellanox PMDs? > > Thanks, > > — > Damjan
