On Fri, 25 Oct 2019 11:55:41 +0100 Bruce Richardson <bruce.richard...@intel.com> wrote:
> On Thu, Oct 24, 2019 at 11:09:26AM -0700, Stephen Hemminger wrote: > > The values in an enum are really global names and not specific > > to the enum in question. This can lead to namespace conflicts > > in applications if a common value is visible. > > > > The DPDK cmdline API has an enum for numeric type values with > > names line UINT32 which could be used or defined in a user > > application. Change these to be prefixed with the enum name > > like other places in DPDK. > > > > Lots of lines changed with no change in actual code > > generated. > > > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > > --- > > Duplicate of this patch from 6 months ago? > http://patches.dpdk.org/patch/52644/ > > /Bruce Yes. one of them should go in. Checkpatch spits out lots of noise because existing code does not conform to style.