On Mon, Oct 14, 2019 at 5:16 PM Gaëtan Rivet <gaetan.ri...@6wind.com> wrote:
> On Mon, Oct 14, 2019 at 04:32:54PM +0200, David Marchand wrote:
> > On Fri, Oct 11, 2019 at 10:56 PM Seth Howell <seth.how...@intel.com> wrote:
> > >
> > > The makefile in drivers/bus/pci specified rte_ethdev as a dependency for
> > > the library. However there are no actual symbols from librte_ethdev used
> > > in librte_bus_pci.
> > >
> > > Including librte_ethdev as a dependency only becomes a problem in some
> > > niche cases like when attempting to build the rte_bus_pci library as a
> > > shared object without building the rte_ethdev library.
> > >
> > > I specifically ran into this when trying to build the DPDK included as
> > > an SPDK submodule on a FreeBSD machine. I figure that since there are no
> > > real dependencies between the two, we should enable building
> > > librte_bus_pci without librte_ethdev.
Fixes: c752998b5e2e ("pci: introduce library and driver")
Cc: sta...@dpdk.org
> > >
> > > Signed-off-by: Seth Howell <seth.how...@intel.com>
> Yes this is fine.
> I've checked, when this Makefile was introduced first in v17.11, this
> dependency was not needed either. This means the Fixes: can go back to
> c752998b5.
>
> Acked-by: Gaetan Rivet <gaetan.ri...@6wind.com>
Applied, thanks.
--
David Marchand
