On Mon, Oct 21, 2019 at 12:56:58PM +0200, Andrzej Ostruszka wrote:
> This patch adds an option to enable link time optimization. In addition
> to LTO option itself (-flto) fat-lto-objects are being used. This is
> because during the build pmdinfogen scans the generated ELF objects to
> find this_pmd_name* symbol in symbol table. Without fat-lto-objects gcc
> produces ELF only with extra symbols for internal use during linking.
>
> Signed-off-by: Andrzej Ostruszka <aostrus...@marvell.com>
> ---
> .travis.yml | 7 ++++
> config/common_base | 5 +++
> config/meson.build | 15 ++++++++
> doc/guides/prog_guide/lto.rst | 36 ++++++++++++++++++++
> doc/guides/rel_notes/release_19_11.rst | 8 +++++
> lib/librte_distributor/rte_distributor.c | 18 +++++-----
> lib/librte_distributor/rte_distributor_v20.c | 18 +++++-----
> lib/librte_lpm/rte_lpm.c | 28 +++++++--------
> lib/librte_lpm/rte_lpm6.c | 16 ++++-----
> lib/librte_timer/rte_timer.c | 20 +++++------
> mk/toolchain/gcc/rte.toolchain-compat.mk | 4 +++
> mk/toolchain/gcc/rte.vars.mk | 12 +++++++
> mk/toolchain/icc/rte.vars.mk | 8 +++++
> 13 files changed, 145 insertions(+), 50 deletions(-)
> create mode 100644 doc/guides/prog_guide/lto.rst
>
> diff --git a/.travis.yml b/.travis.yml
> index 781f9f666..70d221852 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -31,6 +31,7 @@ env:
> - DEF_LIB="static" OPTS="-Denable_kmods=false"
> - DEF_LIB="shared" OPTS="-Denable_kmods=false"
> - DEF_LIB="shared" RUN_TESTS=1 BUILD_DOCS=1
> + - DEF_LIB="shared" OPTS="-Db_lto=true"
>
> matrix:
> include:
> @@ -100,6 +101,12 @@ matrix:
> apt:
> packages:
> - *extra_packages
> + - env: DEF_LIB="shared" OPTS="-Db_lto=true" EXTRA_PACKAGES=1
> + compiler: gcc
> + addons:
> + apt:
> + packages:
> + - *extra_packages
>
>
> script: ./.ci/${TRAVIS_OS_NAME}-build.sh
> diff --git a/config/common_base b/config/common_base
> index 8ef75c203..73a55fdec 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -49,6 +49,11 @@ CONFIG_RTE_FORCE_INTRINSICS=n
> #
> CONFIG_RTE_ARCH_STRICT_ALIGN=n
>
> +#
> +# Enable link time optimization
> +#
> +CONFIG_RTE_ENABLE_LTO=n
> +
> #
> # Compile to share library
> #
> diff --git a/config/meson.build b/config/meson.build
> index 2bafea530..97bbc323b 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -196,3 +196,18 @@ add_project_arguments('-D_GNU_SOURCE', language: 'c')
> if is_freebsd
> add_project_arguments('-D__BSD_VISIBLE', language: 'c')
> endif
> +
> +if get_option('b_lto')
> + if cc.has_argument('-ffat-lto-objects')
> + add_project_arguments('-ffat-lto-objects', language: 'c')
> + else
> + error('compiler does not support fat LTO objects - please turn
> LTO off')
> + endif
> + if cc.get_id() == 'gcc'
> + # workaround for bug 81440
> + if cc.version().version_compare('<8.0')
> + add_project_arguments('-Wno-lto-type-mismatch',
> language: 'c')
> + add_project_link_arguments('-Wno-lto-type-mismatch',
> language: 'c')
> + endif
> + endif
> +endif
Just wondering on this what would be the impact with blindly disabling this
warning? Would we miss any common issues accidentally?
If we keep the current conditional code, suggest we merge the two checks
for gcc and gcc version together into one if statement so we can reduce
indentation level by one.
/Bruce
