Hi Neil, > -----Original Message----- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Monday, February 02, 2015 9:39 PM > To: Chen, Jing D > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files > > On Mon, Feb 02, 2015 at 05:34:43AM +0000, Chen, Jing D wrote: > > Hi Neil, > > > > > -----Original Message----- > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > Sent: Saturday, January 31, 2015 10:02 PM > > > To: Chen, Jing D > > > Cc: dev at dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files > > > > > > On Fri, Jan 30, 2015 at 01:07:19PM +0800, Chen Jing D(Mark) wrote: > > > > From: Jeff Shaw <jeffrey.b.shaw at intel.com> > > > > > > > > Define macros and basic data structure. > > > > Define rte_log wrapper functions. > > > > > > > > Signed-off-by: Jeff Shaw <jeffrey.b.shaw at intel.com> > > > > Signed-off-by: Chen Jing D(Mark) <jing.d.chen at intel.com> > > > > --- > > > > lib/librte_pmd_fm10k/Makefile | 96 ++++++++++++++++ > > > > lib/librte_pmd_fm10k/fm10k.h | 224 > > > +++++++++++++++++++++++++++++++++++++ > > > > lib/librte_pmd_fm10k/fm10k_logs.h | 66 +++++++++++ > > > > 3 files changed, 386 insertions(+), 0 deletions(-) > > > > create mode 100644 lib/librte_pmd_fm10k/Makefile > > > > create mode 100644 lib/librte_pmd_fm10k/fm10k.h > > > > create mode 100644 lib/librte_pmd_fm10k/fm10k_ethdev.c > > > > create mode 100644 lib/librte_pmd_fm10k/fm10k_logs.h > > > > create mode 100644 lib/librte_pmd_fm10k/fm10k_rxtx.c > > > > > > > Why are you adding empty files? > > > > The 2 ".c" files are empty while the 2 ".h" files include code. "Makefile" > includes rules to > > compile the ".c" files, I don't like to break the compile for every single > > patch, > that's why > > the 2 ".c" files are added in this patch. > > > That doesn't really answer the question. Theres no need to add empty files > here. Just add the headers alone and add the empy files on the first commit > where you have code to put in them. Adjust the makefile so that you add > them > into the compilation in the same commit that you populate the file to avoid a > FTBFS error. > Neil
Got you. I'll add the content with new files. Thanks! > > > > > > > Neil > > > > Thanks for your comments. > > Mark > >
