On Tue, Oct 8, 2019 at 6:34 PM Stephen Hemminger
<step...@networkplumber.org> wrote:
>
> The test for cloning changed mbuf would generate an mbuf
> whose length and segments were invalid. This would cause a crash
> if test was run with mbuf debugging enabled.
It could be interesting to add calls to rte_mbuf_check() (not
dependent on the debug build option) at key points in this test.
>
> Fixes: f1022aba76a5 ("app/test: rename mbuf variable")
Wrong Fixes: tag.
Fixes: 4ccd2bb3a9e2 ("app/test: enhance mbuf refcnt check")
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> Acked-by: Olivier Matz <olivier.m...@6wind.com>
> ---
> app/test/test_mbuf.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
> index 2a97afe2044a..aafad0cf6206 100644
> --- a/app/test/test_mbuf.c
> +++ b/app/test/test_mbuf.c
> @@ -332,8 +332,11 @@ testclone_testupdate_testdetach(struct rte_mempool
> *pktmbuf_pool)
> m->next = rte_pktmbuf_alloc(pktmbuf_pool);
> if (m->next == NULL)
> GOTO_FAIL("Next Pkt Null\n");
> + m->nb_segs = 2;
>
> rte_pktmbuf_append(m->next, sizeof(uint32_t));
> + m->pkt_len = 2 * sizeof(uint32_t);
> +
> data = rte_pktmbuf_mtod(m->next, unaligned_uint32_t *);
> *data = MAGIC_DATA;
>
> --
> 2.20.1
>
Applied, thanks.
--
David Marchand
