On Wed, Sep 25, 2019 at 11:42 PM David Christensen
<d...@linux.vnet.ibm.com> wrote:
>
> An ifdef present in eal_memory.c references "RTE_ARCH_PPC64" when
> it should actually use "RTE_ARCH_PPC_64". Simple testing revealed
> that both the PPC_64 and non-PPC_64 versions of the code involved
> work, but the PPC_64 version of the code is retained to be
> consistent with other instances in the same file where mmapped
> memory is accessed in reverse order on Power platforms.
The change itself is not that scary, but just reading this commitlog I
fail to see the impact for an application.
Can you share some light?
>
> Fixes: 66cc45e ("mem: replace memseg with memseg lists")
Fixes sha1 should be on 12 digits.
Should we copy stable ?
> Cc: Anatoly Burakov <anatoly.bura...@intel.com>
>
> Signed-off-by: David Christensen <d...@linux.vnet.ibm.com>
> ---
> lib/librte_eal/linux/eal/eal_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal_memory.c
> b/lib/librte_eal/linux/eal/eal_memory.c
> index 1c089a1ef..1bbdd8a29 100644
> --- a/lib/librte_eal/linux/eal/eal_memory.c
> +++ b/lib/librte_eal/linux/eal/eal_memory.c
> @@ -688,7 +688,7 @@ remap_segment(struct hugepage_file *hugepages, int
> seg_start, int seg_end)
> return -1;
> }
>
> -#ifdef RTE_ARCH_PPC64
> +#ifdef RTE_ARCH_PPC_64
> /* for PPC64 we go through the list backwards */
> for (cur_page = seg_end - 1; cur_page >= seg_start;
> cur_page--, ms_idx++) {
> --
> 2.18.1
>
Thanks.
--
David Marchand
