Re: [dpdk-dev] [EXT] Re: [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

[David Marchand]

On Tue, Oct 15, 2019 at 10:56 AM Pavan Nikhilesh Bhagavatula
<pbhagavat...@marvell.com> wrote:
>
>
>
> >-----Original Message-----
> >From: David Marchand <david.march...@redhat.com>
> >Sent: Tuesday, October 15, 2019 2:16 PM
> >To: Jerin Jacob Kollanukkaran <jer...@marvell.com>; Stephen
> >Hemminger <step...@networkplumber.org>
> >Cc: dev <dev@dpdk.org>; Pavan Nikhilesh Bhagavatula
> ><pbhagavat...@marvell.com>; dpdk stable <sta...@dpdk.org>; Aaron
> >Conole <acon...@redhat.com>
> >Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one
> >when divisor is 32bit
> >On Tue, Sep 3, 2019 at 9:17 PM <pbhagavat...@marvell.com> wrote:
> >>
> >> From: Pavan Nikhilesh <pbhagavat...@marvell.com>
> >>
> >> Fix off by one error in 64bit reciprocal division when divisor is 32bit.
> >>
> >> Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide")
> >> Cc: sta...@dpdk.org
> >>
> >> Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com>
> >
> >Any review?
> >
> >Are we missing an update in the unit test to catch this issue?
> >Thanks.
>
> We actually caught it in a unit test
> >test_reciprocal_division

We had this problem since the very start then.

Both reciprocal_division and reciprocal_division_perf are in the "perf" list.
Can they be promoted to the standard list?


-- 
David Marchand