Problem statement: As of now vdev device do not support IOMMU. vdev device used to custom solution, even for software drives like openssl uses vdev. I feel its not advisable to put iommu in vdev. moving the changes to vdev will effect rest of the vdev drives. That will be big efforts. Every vdev drivers has their own implementation. Need better design to move it to vdev or common place.
Regards, S.Amarnath -----Original Message----- From: Jerin Jacob <jerinjac...@gmail.com> Sent: Tuesday, October 15, 2019 1:47 PM To: Somalapuram, Amaranath <amaranath.somalapu...@amd.com> Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 5/6] crypto/ccp: enable IOMMU for CCP [CAUTION: External Email] On Tue, Oct 15, 2019 at 12:32 PM <asoma...@amd.com> wrote: > > From: Amaranath Somalapuram <asoma...@amd.com> > > CCP use vdev framework, and vdev framework don’t support IOMMU. > Adding custom IOMMU support for AMD CCP drives. > Cc: sta...@dpdk.org > > + if (iommu_mode == 2) > + pci->kdrv = RTE_KDRV_VFIO; > + else if (iommu_mode == 0) > + pci->kdrv = RTE_KDRV_IGB_UIO; > + else if (iommu_mode == 1) > + pci->kdrv = RTE_KDRV_UIO_GENERIC; The crypto driver should not have iommu mode-specific handling. I am not sure about the problem statement. If the problem is, iommu support for PCI based vdev device then move the solution to common layer so that everyone can use it. If not, please share the problem statement
