Re: [dpdk-dev] [PATCH v4 00/17] sched: subport level configuration of pipe nodes

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Monday, October 14, 2019 1:10 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitre...@intel.com>
> Subject: [PATCH v4 00/17] sched: subport level configuration of pipe nodes
> 
> This patchset refactors the dpdk qos sched library to allow subport
> level configuration flexibility of the pipe nodes.
> 
> Currently, all parameters for the pipe nodes (subscribers)
> configuration are part of the port level structure which forces
> all groups of subscribers (pipes) in different subports to
> have similar configurations in terms of their number, queue sizes,
> traffic-classes, etc.
> 
> The new implementation moves pipe nodes configuration parameters
> from port level to subport level structure. This allows different
> subports of the same port to have different configuration for the
> pipe nodes, for examples- number of pipes, queue sizes, pipe
> profiles, etc.
> 
> In order to keep the implementation complexity under control, all
> pipes within the same subport share the same configuration for queue
> sizes.
> 
> v4:
> - remove deprecation note
> - rebase on current dpdk head
> - add 64-bit values support
> 

Hi Jasvinder,

I think the 64-bit counter support is a distinct unrelated feature, and I 
suggest we send a separate patchset for it. It also saves us re-reviewing the 
large patchset that was already reviewed?

Regards,
Cristian